Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise VisibilityListMaxQPS limit for local docker-compose env #4238

Merged
merged 2 commits into from
Jun 1, 2021

Conversation

longquanzheng
Copy link
Collaborator

@longquanzheng longquanzheng commented May 28, 2021

What changed?
Raise VisibilityListMaxQP limit for local docker-compose env

Why?
For #3900

How did you test it?
Local test

cadence_1        | {"level":"info","ts":"2021-05-28T23:23:22.427Z","msg":"First loading dynamic config","service":"cadence-frontend","key":"frontend.visibilityListMaxQPS,domainName:samples-domain,clusterName:primary","value":"10000","default-value":"10000","logging-call-at":"config.go:93"}

Potential risks
No

Release notes

Documentation Changes

@longquanzheng longquanzheng changed the title Raise VisibilityListMaxQP limit for local docker-compose env Raise VisibilityListMaxQPS limit for local docker-compose env Jun 1, 2021
@github-actions github-actions bot merged commit de3a6ac into master Jun 1, 2021
@github-actions github-actions bot deleted the qlong-list-max-qps branch June 1, 2021 19:13
@github-actions github-actions bot removed the automerge label Jun 1, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3093d18a-afa2-4b83-add1-1836ada0dc45

  • 6 of 8 (75.0%) changed or added relevant lines in 1 file are covered.
  • 52 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.005%) to 60.24%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/frontend/service.go 6 8 75.0%
Files with Coverage Reduction New Missed Lines %
client/history/client.go 2 44.78%
client/history/metricClient.go 2 49.43%
common/persistence/executionStore.go 2 75.75%
common/persistence/statsComputer.go 2 96.43%
service/history/handler.go 2 46.67%
common/persistence/cassandra/cassandraPersistence.go 4 56.93%
service/frontend/workflowHandler.go 4 58.35%
service/history/shard/context.go 8 62.58%
service/history/historyEngine.go 9 71.18%
service/history/execution/context.go 17 69.08%
Totals Coverage Status
Change from base Build 9d9f1bd9-d7f1-4cc5-9ac7-d1a0e2539b0b: 0.005%
Covered Lines: 88524
Relevant Lines: 146951

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants