Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce metrics cardinality replication.TaskStore #4981

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

vytautas-karpavicius
Copy link
Contributor

What changed?
Emit replication cache size as timer, to get a percentile view instead of metric per each shard.

Why?
Turns out, having metric per shard is very expensive. Dashboard become too sluggish to work with.
Keep higher level metrics only and log warning when cache is full, for debugging specific shards.

How did you test it?

Potential risks

Release notes

Documentation Changes

@vytautas-karpavicius vytautas-karpavicius requested a review from a team August 31, 2022 08:11
@coveralls
Copy link

Pull Request Test Coverage Report for Build 0182f365-4f4e-4bbb-8547-57534eeb5660

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • 127 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.02%) to 57.78%

Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 1 88.6%
common/backoff/retry.go 2 92.11%
common/persistence/statsComputer.go 3 94.64%
common/task/fifoTaskScheduler.go 3 84.54%
common/persistence/serialization/parser.go 4 65.41%
common/persistence/serialization/thrift_decoder.go 4 61.22%
service/history/task/transfer_standby_task_executor.go 4 86.79%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 6 56.99%
common/persistence/nosql/nosqlplugin/cassandra/workflowUtils.go 11 74.22%
common/persistence/sql/workflowStateMaps.go 11 85.56%
Totals Coverage Status
Change from base Build 0182eb95-a47b-4b48-8f18-de9548f005fc: -0.02%
Covered Lines: 84371
Relevant Lines: 146020

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants