Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add domain_type and cluster_groups tags #4990

Merged

Conversation

vytautas-karpavicius
Copy link
Contributor

@vytautas-karpavicius vytautas-karpavicius commented Sep 5, 2022

What changed?

  • Added domain_type tag to emit whether domain is global or local when emitting active_cluster gauge.
  • Added cluster_group tag to indicate which cluster group this is. It is a sorted and concatenated string of enabled clusters in the group.

Why?
With this addition it will be possible to detect whether global domain is active in several clusters and alert on that.

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Sep 5, 2022

Pull Request Test Coverage Report for Build 01831b95-9463-4eee-8ce6-535834f67557

  • 24 of 24 (100.0%) changed or added relevant lines in 4 files are covered.
  • 159 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-0.02%) to 57.31%

Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.26%
common/persistence/historyManager.go 2 66.67%
common/persistence/persistenceMetricClients.go 2 56.86%
service/history/task/transfer_active_task_executor.go 2 72.13%
service/matching/matcher.go 2 91.46%
common/persistence/statsComputer.go 3 94.64%
common/persistence/serialization/parser.go 4 65.41%
common/persistence/serialization/thrift_decoder.go 4 61.22%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 6 59.55%
common/persistence/sql/workflowStateMaps.go 12 85.34%
Totals Coverage Status
Change from base Build 01831387-3382-4d09-8153-bf4c32fdd209: -0.02%
Covered Lines: 85146
Relevant Lines: 148570

💛 - Coveralls

@vytautas-karpavicius vytautas-karpavicius marked this pull request as ready for review September 5, 2022 09:10
@vytautas-karpavicius vytautas-karpavicius requested a review from a team September 5, 2022 09:10
@vytautas-karpavicius vytautas-karpavicius changed the title Add domain_type tag Add domain_type and cluster_groups tags Sep 5, 2022
@vytautas-karpavicius vytautas-karpavicius merged commit 5fd0127 into uber:master Sep 8, 2022
@vytautas-karpavicius vytautas-karpavicius deleted the domain-type-tag branch September 8, 2022 07:24
Groxx pushed a commit that referenced this pull request Oct 6, 2022
* Add domain_type tag

* Add cluster_group tag
Groxx pushed a commit that referenced this pull request Oct 6, 2022
* Add domain_type tag

* Add cluster_group tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants