Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dynamic config for gRPC message size #5002

Merged

Conversation

vytautas-karpavicius
Copy link
Contributor

@vytautas-karpavicius vytautas-karpavicius commented Sep 26, 2022

What changed?
Dropped dynamic config for max gRPC message size.

Why?
We keep forgetting to set this value for newly provisioned clusters. Which then causes replication issues.
Just use max value set in static yarpc config instead.

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Sep 26, 2022

Pull Request Test Coverage Report for Build 01837d87-6678-4dd3-b1a5-304163ab9b1b

  • 4 of 7 (57.14%) changed or added relevant lines in 5 files are covered.
  • 86 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.03%) to 57.26%

Changes Missing Coverage Covered Lines Changed/Added Lines %
client/history/client.go 0 1 0.0%
service/history/config/config.go 2 3 66.67%
service/history/handler.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
service/history/task/transfer_standby_task_executor.go 2 86.82%
common/persistence/statsComputer.go 3 94.64%
service/matching/taskListManager.go 5 76.37%
common/persistence/serialization/parser.go 8 63.91%
common/persistence/serialization/thrift_decoder.go 8 57.14%
service/history/execution/mutable_state_task_refresher.go 10 56.65%
common/persistence/sql/workflowStateMaps.go 20 83.62%
common/persistence/serialization/getters.go 28 60.21%
Totals Coverage Status
Change from base Build 01837bba-bb94-45f3-a6b7-48e1ddb3cf13: -0.03%
Covered Lines: 85124
Relevant Lines: 148662

💛 - Coveralls

@vytautas-karpavicius vytautas-karpavicius marked this pull request as ready for review September 26, 2022 17:01
@vytautas-karpavicius vytautas-karpavicius requested a review from a team September 26, 2022 17:01
@vytautas-karpavicius vytautas-karpavicius merged commit 23abf96 into uber:master Sep 27, 2022
@vytautas-karpavicius vytautas-karpavicius deleted the drop-dynamic-grpc-size branch September 27, 2022 08:19
Groxx pushed a commit that referenced this pull request Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants