Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLS ServerName as CLI option for Cadence Cassandra Tool #5011

Merged
merged 5 commits into from
Nov 22, 2022

Conversation

sonpham96
Copy link
Contributor

@sonpham96 sonpham96 commented Oct 10, 2022

What changed?

  • Add ServerName as CLI option for cadence-cassandra-tool
  • Pass the ServerName to the cql client TLS config

Why?
Fix #5010.

How did you test it?
I built the cadence-server Docker image then execute the following command:

docker run --rm ubercadence/server:master --tls -u <user> --pw <password> --ep <endpoint> -p 9042 --tls-server-name <endpoint> -k cadence update-schema -d /etc/cadence/schema/cassandra/cadence/versioned

The error did not appear and the command finished successfully.

Potential risks
N/A

Release notes

Documentation Changes

@CLAassistant
Copy link

CLAassistant commented Oct 10, 2022

CLA assistant check
All committers have signed the CLA.

@sonpham96 sonpham96 force-pushed the cadence-cassandra-tool-server-name branch from 57d0229 to bef1df9 Compare October 12, 2022 03:16
@davidporter-id-au
Copy link
Contributor

Hey there, this just needs the lint errors fixed. The build has details

@sonpham96
Copy link
Contributor Author

Hey there, this just needs the lint errors fixed. The build has details

Formatted the code with make fmt. Hope it will fix the lint errors. However, it looks like the build is blocked. How do I trigger it?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018441c7-d772-4009-b5e8-94c8ff6c8505

  • 0 of 6 (0.0%) changed or added relevant lines in 2 files are covered.
  • 128 unchanged lines in 15 files lost coverage.
  • Overall coverage decreased (-0.03%) to 57.273%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tools/cassandra/handler.go 0 1 0.0%
tools/cassandra/main.go 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
service/history/queue/transfer_queue_processor_base.go 1 77.62%
common/task/weightedRoundRobinTaskScheduler.go 1 89.64%
service/matching/taskListManager.go 2 76.62%
common/membership/hashring.go 2 83.54%
service/history/queue/timer_gate.go 3 95.83%
service/history/execution/mutable_state_task_refresher.go 3 65.82%
common/task/fifoTaskScheduler.go 3 84.54%
service/history/task/transfer_standby_task_executor.go 4 86.4%
service/history/queue/timer_queue_processor_base.go 4 77.48%
common/persistence/statsComputer.go 6 93.57%
Totals Coverage Status
Change from base Build 01843ed5-ee07-42df-ab7e-c7e4b88b829a: -0.03%
Covered Lines: 85196
Relevant Lines: 148753

💛 - Coveralls

@Shaddoll Shaddoll merged commit 1a52714 into uber:master Nov 22, 2022
@sonpham96 sonpham96 deleted the cadence-cassandra-tool-server-name branch March 15, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TLS ServerName as CLI option for Cadence Cassandra Tool
5 participants