Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UpdateTime to uninitialized workflow execution record and update logic to set the update time #5014

Merged
merged 5 commits into from
Nov 16, 2022

Conversation

neil-xie
Copy link
Contributor

@neil-xie neil-xie commented Oct 27, 2022

What changed?
Added updateTime field to uninitialized workflow execution requests, update the updateTime field to use current UTC time to make the logic consistent, same for record start/closed/upsert/uninitialized workflow executions.

Why?

How did you test it?
Unit test and manually local test

Potential risks

Release notes

Documentation Changes

@neil-xie neil-xie changed the title Cdnc 3080 Add UpdateTime to uninitialized workflow execution record and update logic to set the update time Oct 27, 2022
@coveralls
Copy link

coveralls commented Oct 28, 2022

Pull Request Test Coverage Report for Build 01848288-a39d-41ce-bfd4-efd058279efb

  • 10 of 14 (71.43%) changed or added relevant lines in 7 files are covered.
  • 95 unchanged lines in 20 files lost coverage.
  • Overall coverage decreased (-0.03%) to 57.249%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/persistence/persistence-tests/dbVisibilityPersistenceTest.go 0 1 0.0%
common/persistence/visibilitySingleManager.go 0 1 0.0%
service/history/historyEngine.go 0 1 0.0%
service/history/task/transfer_task_executor_base.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
service/history/queue/transfer_queue_processor_base.go 1 77.62%
common/membership/hashring.go 2 83.54%
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/persistence/executionManager.go 2 78.83%
common/persistence/statsComputer.go 2 94.64%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
service/history/execution/mutable_state_builder.go 2 68.75%
service/history/execution/mutable_state_util.go 2 36.14%
service/history/task/transfer_active_task_executor.go 2 72.28%
service/matching/matcher.go 2 91.46%
Totals Coverage Status
Change from base Build 01847c55-385e-4e36-98e7-e60ecb8cbf87: -0.03%
Covered Lines: 85046
Relevant Lines: 148555

💛 - Coveralls

@neil-xie neil-xie requested a review from a team November 1, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants