Enhance workflowDeletionTaskJitterRange to handle deletes piling up when many workflows have finished at the same time. #5020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen many workflows have finished at the same time. * Fix panics when values < 1 are provided * Randomize the timestamp on a second granularity so that deletes are more spread out than before. * Default to 60 minutes.
Groxx
approved these changes
Nov 2, 2022
| retentionDuration := (time.Duration(retentionInDays) * time.Hour * 24) + (time.Duration(rand.Intn(workflowDeletionTaskJitterRange)) * time.Minute) | ||
| retentionDuration := (time.Duration(retentionInDays) * time.Hour * 24) | ||
| if workflowDeletionTaskJitterRange > 1 { | ||
| retentionDuration += time.Duration(rand.Intn(workflowDeletionTaskJitterRange*60)) * time.Second |
There was a problem hiding this comment.
alternatively: random float within that range, then the order of multiplication doesn't matter. or multiply by time.Minute before rand.Intn.
though that's probably a fair bit more casting, so also meh - this works, and it's probably a good enough spread of values 👍.
maybe with generics we'll have a more concise way to do this.
…hen many workflows have finished at the same time. * Fix panics when values < 1 are provided * Randomize the timestamp on a second granularity so that deletes are more spread out than before. * Default to 60 minutes.
Pull Request Test Coverage Report for Build 01843ae4-aa5d-49f3-8d54-3ffa2e52e223
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more spread out than before.
Tested with current unit tests which change the value