Add FirstExecutionRunID to mutable state #5031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
force-pushed
the
fix-parent-close-policy
branch
9 times, most recently
from
1773fa9
to
05dcc48
Compare
Shaddoll
changed the title
Shaddoll
force-pushed
the
fix-parent-close-policy
branch
from
05dcc48
to
bdd2052
Compare
| @@ -152,6 +153,7 @@ func FromInternalWorkflowExecutionInfo(executionInfo *persistence.InternalWorkfl | |||
| CompletionEventEncoding: string(common.EncodingTypeEmpty), | |||
| VersionHistoriesEncoding: string(common.EncodingTypeEmpty), | |||
| InitiatedID: common.EmptyEventID, | |||
| FirstExecutionRunID: MustParseUUID(executionInfo.FirstExecutionRunID), | |||
There was a problem hiding this comment.
Is there any possibility of this being an invalid UUID? I'm always a little scared of using MustParse for places like this
There was a problem hiding this comment.
Looking below at the builder - from a naïve perspective this looks maybe it could be an invalid uuid, or at least a nil one
There was a problem hiding this comment.
MustParseUUID works with empty string
davidporter-id-au
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added FirstExecutionRunID to mutable state which gets persisted in DB. Now we don't rely on workflow execution started event for this information.
This partially picks temporalio/temporal#365
Why?
See temporalio/temporal#365
How did you test it?
unit test, integration test and local test on laptop
Potential risks
There might be backward compatibility issue, and we must make sure the old mutable state can still be read from database.
Release notes
Documentation Changes