Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposing the ability to pull CQL changesets #5047

Merged
merged 6 commits into from
Dec 13, 2022
Merged

Exposing the ability to pull CQL changesets #5047

merged 6 commits into from
Dec 13, 2022

Conversation

davidporter-id-au
Copy link
Contributor

@davidporter-id-au davidporter-id-au commented Dec 12, 2022 •
edited

Exposing SQL statements during update operations

Why?
Access to the actual SQL statements is helpful for building some tooling regarding schema automation upgrading.

How did you test it?
Unit tests

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Dec 12, 2022 •
edited

Pull Request Test Coverage Report for Build 01850ac0-a0ca-434c-b87d-e9f7ddd102b1

  • 0 of 14 (0.0%) changed or added relevant lines in 1 file are covered.
  • 14 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.09%) to 57.32%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tools/common/schema/updatetask.go 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
common/types/shared.go 1 41.76%
tools/common/schema/updatetask.go 1 41.79%
common/membership/hashring.go 2 83.54%
common/task/weightedRoundRobinTaskScheduler.go 2 89.12%
service/matching/matcher.go 2 91.46%
service/matching/taskListManager.go 2 76.62%
common/types/mapper/thrift/shared.go 4 63.17%
Totals Coverage Status
Change from base Build 0185087d-bb38-4c03-8b2c-1ff954dc6d9e: 0.09%
Covered Lines: 85257
Relevant Lines: 148739
💛 - Coveralls

Shaddoll
Shaddoll reviewed Dec 12, 2022
View reviewed changes
tools/common/schema/updatetask.go Outdated
cqlStmts []string
ChangeSet struct {
Version string
Manifest *manifest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth exposing manifest?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps not, I don't have strong opinions, I can hide it

@davidporter-id-au davidporter-id-au enabled auto-merge (squash) December 13, 2022 09:11
@davidporter-id-au davidporter-id-au merged commit 4a2c9af into master Dec 13, 2022
@davidporter-id-au davidporter-id-au deleted the feature/exposing-schema-changsets branch December 13, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaddoll Shaddoll Shaddoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidporter-id-au @coveralls @Shaddoll