Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #5065

Merged
merged 2 commits into from
Jan 11, 2023
Merged

Update dependencies #5065

merged 2 commits into from
Jan 11, 2023

Conversation

mindaugasbarcauskas
Copy link
Contributor

What changed?
Updated some cadence server dependencies to higher minor versions.

Why?
Best practice to keep dependencies up to date.

How did you test it?
Pipeline build.

Potential risks
Build / Functionality issues with new dependencies.

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Jan 6, 2023 •
edited

Pull Request Test Coverage Report for Build 0185a0f9-ca4d-46cc-9ea4-d5bf24d23298

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 112 unchanged lines in 22 files lost coverage.
  • Overall coverage increased (+0.02%) to 57.213%
Files with Coverage Reduction New Missed Lines %
common/types/shared.go 1 41.76%
client/history/client.go 2 38.1%
client/history/metricClient.go 2 45.3%
common/persistence/historyManager.go 2 66.67%
common/task/fifoTaskScheduler.go 2 85.57%
common/task/weightedRoundRobinTaskScheduler.go 2 89.12%
service/history/execution/mutable_state_builder.go 2 68.79%
service/history/handler.go 2 47.15%
service/history/shard/context.go 2 67.3%
service/history/task/transfer_active_task_executor.go 2 72.22%
Totals Coverage Status
Change from base Build 01859941-aac7-430f-b236-910fef5e6d8e: 0.02%
Covered Lines: 84947
Relevant Lines: 148476
💛 - Coveralls

davidporter-id-au
davidporter-id-au approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@davidporter-id-au davidporter-id-au left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's verify

@mindaugasbarcauskas mindaugasbarcauskas merged commit f2a58e2 into master Jan 11, 2023
@mindaugasbarcauskas mindaugasbarcauskas deleted the update-dependencies-3 branch January 11, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidporter-id-au davidporter-id-au davidporter-id-au approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mindaugasbarcauskas @coveralls @davidporter-id-au