Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit workflow counts per workflow type metrics #5082

Merged
merged 8 commits into from
Feb 9, 2023
Merged

Conversation

neil-xie
Copy link
Contributor

@neil-xie neil-xie commented Feb 8, 2023

What changed?
Emit workflow counts per workflow type metrics
Fix the es query to exclude uninitialized workflow execution records

Why?

How did you test it?
Tested at staging2, added new panel to dashboard to see the results

Potential risks

Release notes

Documentation Changes

@allenchen2244
Copy link
Contributor

Sorry, we should be fixing the names if we plan on adding more workflows to esanalyzer. I feel like having 1 wf do both things is a gross violation of SRP

@coveralls
Copy link

coveralls commented Feb 8, 2023

Pull Request Test Coverage Report for Build 0186337d-bf94-454b-bfbf-3fef85d64937

  • 59 of 127 (46.46%) changed or added relevant lines in 3 files are covered.
  • 22 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.2%) to 57.271%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/worker/esanalyzer/analyzer.go 0 12 0.0%
service/worker/esanalyzer/domainWorkflowTypeCountWorkflow.go 58 114 50.88%
Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.26%
service/history/queue/transfer_queue_processor_base.go 1 77.62%
common/backoff/retry.go 2 92.11%
common/persistence/historyManager.go 2 66.67%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
common/persistence/dataManagerInterfaces.go 3 59.07%
service/history/execution/mutable_state_task_refresher.go 3 56.65%
common/task/fifoTaskScheduler.go 4 82.47%
service/history/task/fetcher.go 4 91.24%
Totals Coverage Status
Change from base Build 01863367-cd39-4b94-a6e2-986b714838b3: 0.2%
Covered Lines: 85126
Relevant Lines: 148637

💛 - Coveralls

@allenchen2244 allenchen2244 self-requested a review February 8, 2023 23:48
Copy link
Contributor

@allenchen2244 allenchen2244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@neil-xie neil-xie merged commit 3b5c2b6 into master Feb 9, 2023
@neil-xie neil-xie deleted the neilx_CDNC1252 branch February 9, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants