Small refactoring of task writer #5092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
force-pushed
the
refactor-matching
branch
from
26ad962
to
9599bbd
Compare
Shaddoll
force-pushed
the
refactor-matching
branch
from
9599bbd
to
5d94c75
Compare
| } | ||
| } | ||
|
|
||
| func (w *taskWriter) Start(block taskIDBlock) { | ||
| func (w *taskWriter) Start() error { |
There was a problem hiding this comment.
this this called anywhere else? I would just be worried about calling SetAckLevel erroneously
There was a problem hiding this comment.
its not, so that's all good
There was a problem hiding this comment.
SetAckLevel doesn't return error
it's called inside start method of tasklistmanager
davidporter-id-au
approved these changes
Feb 13, 2023
| } | ||
| } | ||
|
|
||
| func (w *taskWriter) Start(block taskIDBlock) { | ||
| func (w *taskWriter) Start() error { |
There was a problem hiding this comment.
its not, so that's all good
| @@ -172,7 +225,7 @@ writerLoop: | |||
| maxReadLevel = taskIDs[i] | |||
| } | |||
|
|
|||
| r, err := w.tlMgr.db.CreateTasks(tasks) | |||
| r, err := w.db.CreateTasks(tasks) | |||
There was a problem hiding this comment.
nice, that bidirectional reference thing is confusing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Move some methods from taskListManagerImpl to taskWriter
Why?
These methods are only used by taskWriter, thus it can improve the readability of the code.
How did you test it?
Potential risks
Release notes
Documentation Changes