Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactoring of taskReader #5095

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Small refactoring of taskReader #5095

merged 1 commit into from
Feb 15, 2023

Conversation

Shaddoll
Copy link
Contributor

@Shaddoll Shaddoll commented Feb 14, 2023 •
edited

What changed?

  • Add some fields to taskReader from taskListManager
  • Small improvement on retry logic

Why?
Improve readability
The goal is to remove taskListManager field from taskReader

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Feb 14, 2023 •
edited

Pull Request Test Coverage Report for Build 018652da-d794-4d05-96d7-e18b0a06b073

  • 51 of 56 (91.07%) changed or added relevant lines in 3 files are covered.
  • 112 unchanged lines in 19 files lost coverage.
  • Overall coverage decreased (-0.06%) to 57.128%
Changes Missing Coverage Covered Lines Changed/Added Lines %
service/matching/taskReader.go 45 50 90.0%
Files with Coverage Reduction New Missed Lines %
common/types/shared.go 1 41.76%
client/history/client.go 2 38.1%
client/history/metricClient.go 2 45.3%
common/cache/lru.go 2 92.2%
common/task/weightedRoundRobinTaskScheduler.go 2 89.12%
service/history/execution/mutable_state_util.go 2 36.04%
service/history/handler.go 2 47.15%
service/history/task/transfer_active_task_executor.go 2 72.22%
common/persistence/statsComputer.go 3 93.57%
common/persistence/serialization/parser.go 4 62.41%
Totals Coverage Status
Change from base Build 0186525a-7a5f-4f9c-8036-b101d2ce54bf: -0.06%
Covered Lines: 84900
Relevant Lines: 148614
💛 - Coveralls

@Shaddoll Shaddoll force-pushed the refactor-matching branch 5 times, most recently from 87903fc to e22c2ca Compare February 14, 2023 22:50
davidporter-id-au
davidporter-id-au reviewed Feb 14, 2023
View reviewed changes
service/matching/taskListManager.go
}
return persistence.IsTransientError(err)
}),
backoff.WithRetryableError(persistence.IsTransientError),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm.. not related to this change, but we need to change persistence.IsTransientError to use errors.is/as

@Shaddoll Shaddoll merged commit 68a7614 into uber:master Feb 15, 2023
@Shaddoll Shaddoll deleted the refactor-matching branch February 15, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidporter-id-au davidporter-id-au davidporter-id-au approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Shaddoll @coveralls @davidporter-id-au