Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a helper function to handle ConditionFailedError #5102

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

Shaddoll
Copy link
Contributor

What changed?

  • Create a helper function to handle ConditionFailedError
  • Use errors.As to check error type

Why?
To make the error handling logic consistent in matching

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Feb 16, 2023

Pull Request Test Coverage Report for Build 01865c35-0889-4b64-960b-a675f5d0c0a8

  • 11 of 22 (50.0%) changed or added relevant lines in 3 files are covered.
  • 103 unchanged lines in 15 files lost coverage.
  • Overall coverage increased (+0.003%) to 57.162%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/matching/taskReader.go 2 5 40.0%
service/matching/taskListManager.go 6 14 42.86%
Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 1 89.64%
service/matching/taskWriter.go 1 85.37%
common/persistence/sql/sqlExecutionStore.go 2 63.68%
common/task/fifoTaskScheduler.go 2 84.54%
common/util.go 2 52.31%
service/history/execution/mutable_state_builder.go 2 68.82%
service/history/task/transfer_active_task_executor.go 2 72.15%
service/history/task/transfer_standby_task_executor.go 2 87.66%
service/matching/taskReader.go 2 88.94%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 60.0%
Totals Coverage Status
Change from base Build 01865b3a-aa37-4435-ad6a-05e6646a9788: 0.003%
Covered Lines: 84971
Relevant Lines: 148650

💛 - Coveralls

@Shaddoll Shaddoll merged commit 04a6c92 into uber:master Feb 17, 2023
@Shaddoll Shaddoll deleted the refactor-matching branch February 17, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants