Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove maxQPS from sql plugin documentation #5107

Merged
merged 2 commits into from
Feb 20, 2023

Conversation

mantas-sidlauskas
Copy link
Contributor

What changed?
Remove maxQPS from configuration example

Why?
This parameter is not supported

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 01866e1a-db2a-49d7-a176-0805a0cccf9e

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 145 unchanged lines in 18 files lost coverage.
  • Overall coverage increased (+0.03%) to 57.233%

Files with Coverage Reduction New Missed Lines %
common/persistence/executionManager.go 2 78.89%
common/persistence/historyManager.go 2 66.67%
common/persistence/statsComputer.go 2 95.71%
common/task/weightedRoundRobinTaskScheduler.go 2 89.12%
service/matching/matcher.go 2 91.46%
common/task/fifoTaskScheduler.go 3 84.54%
service/history/task/fetcher.go 3 91.75%
common/persistence/serialization/parser.go 4 65.41%
common/persistence/serialization/thrift_decoder.go 4 61.22%
service/matching/taskListManager.go 4 78.38%
Totals Coverage Status
Change from base Build 01866e09-ef61-4f99-bb16-5269a1ccbd27: 0.03%
Covered Lines: 85102
Relevant Lines: 148694

💛 - Coveralls

Copy link
Contributor

@mindaugasbarcauskas mindaugasbarcauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mindaugasbarcauskas mindaugasbarcauskas merged commit 35e2212 into uber:master Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants