Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visiblity shard id to open source stuff #5123

Merged
merged 9 commits into from
Feb 28, 2023
Merged

Conversation

allenchen2244
Copy link
Contributor

@allenchen2244 allenchen2244 commented Feb 28, 2023

What changed?
Add shard_id to open source visiblity.

Why?
For open source customers

How did you test it?
Unit/int tests pass

Potential risks
Open source break for open source users not uber

Release notes
Update schemas for database solution that is needed

@coveralls
Copy link

Pull Request Test Coverage Report for Build 01869636-5314-4c19-8ee5-a00cf0938281

  • 25 of 29 (86.21%) changed or added relevant lines in 8 files are covered.
  • 137 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-0.08%) to 57.146%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/persistence/persistence-tests/dbVisibilityPersistenceTest.go 0 1 0.0%
common/persistence/nosql/nosqlplugin/cassandra/visibility.go 9 12 75.0%
Files with Coverage Reduction New Missed Lines %
service/history/queue/transfer_queue_processor_base.go 1 77.62%
common/cache/lru.go 2 92.2%
common/persistence/nosql/nosqlplugin/cassandra/visibility.go 2 50.34%
common/task/weightedRoundRobinTaskScheduler.go 2 88.6%
service/matching/matcher.go 2 91.46%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 59.55%
common/persistence/statsComputer.go 6 93.57%
service/history/task/transfer_standby_task_executor.go 6 87.24%
common/persistence/serialization/parser.go 8 63.91%
common/persistence/serialization/thrift_decoder.go 8 57.14%
Totals Coverage Status
Change from base Build 01869460-5d34-4f7e-806c-65ae42a65489: -0.08%
Covered Lines: 85116
Relevant Lines: 148944

💛 - Coveralls

@allenchen2244 allenchen2244 changed the title Visiblity shard id os WIP Visiblity shard id to open source stuff Feb 28, 2023
Copy link
Contributor

@neil-xie neil-xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@allenchen2244 allenchen2244 enabled auto-merge (squash) February 28, 2023 23:33
@allenchen2244 allenchen2244 merged commit 5619c98 into master Feb 28, 2023
@allenchen2244 allenchen2244 deleted the visiblity-shard-id-os branch February 28, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants