Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pinot visibility manager and visibility store #5172

Closed
wants to merge 15 commits into from
Closed

Conversation

neil-xie
Copy link
Contributor

What changed?
Added pinot config and pinot as a new option for advance visibility store
Added pinot visibility dual manager
Added pinot visibility store to support CRUD operations of Pinot
Added new indexer message type for pinot
Added unit test for pinot visibility store

Why?
ES is going to be deprecated in Uber, so we are adding support for Pinot

How did you test it?
Unit test and local test

Potential risks

Release notes

Documentation Changes

@neil-xie neil-xie force-pushed the CDNC-4362 branch 2 times, most recently from 704bf39 to 1256c3d Compare March 30, 2023 01:59
@coveralls
Copy link

coveralls commented Mar 30, 2023

Pull Request Test Coverage Report for Build 018733b1-b969-4eca-ba58-710c763e5089

  • 244 of 778 (31.36%) changed or added relevant lines in 5 files are covered.
  • 47 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.1%) to 56.942%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/server/cadence/server.go 0 7 0.0%
common/persistence/client/factory.go 3 36 8.33%
common/persistence/pinotiVsibilityDualManager.go 0 189 0.0%
common/persistence/Pinot/pinotVisibilityStore.go 240 545 44.04%
Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
service/history/shard/context.go 2 66.52%
service/history/task/transfer_standby_task_executor.go 2 87.24%
service/matching/matcher.go 2 90.65%
common/cache/lru.go 3 90.73%
service/history/task/fetcher.go 3 91.75%
common/task/fifoTaskScheduler.go 4 83.51%
service/history/queue/timer_queue_processor_base.go 7 77.48%
service/history/execution/mutable_state_task_refresher.go 22 66.46%
Totals Coverage Status
Change from base Build 018730a3-9e41-46e0-a95a-718fc884a759: -0.1%
Covered Lines: 85485
Relevant Lines: 150126

💛 - Coveralls

@neil-xie neil-xie changed the base branch from master to CDNC-4184 April 6, 2023 17:26
@neil-xie neil-xie deleted the branch CDNC-4184 April 8, 2023 05:11
@neil-xie neil-xie closed this Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants