add more logs around unsupported version for consistent query #5287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidporter-id-au
approved these changes
May 12, 2023
service/history/decision/handler.go
Outdated
| @@ -730,6 +730,8 @@ func (handler *handlerImpl) handleBufferedQueries( | |||
| buffered := queryRegistry.GetBufferedIDs() | |||
| handler.logger.Info( | |||
| "failing query because worker does not support consistent query", | |||
| tag.Dynamic("clientImpl", clientImpl), | |||
| tag.Dynamic("clientFeatureVersion", clientFeatureVersion), | |||
There was a problem hiding this comment.
did you want to make this a proper tag maybe? also I think we use kebab-case with logs client-feature-version maybe a string tag?
Pull Request Test Coverage Report for Build 01881166-0419-4c52-8d63-8cc731ec0594
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add some more logs since this is happening and we don't have any idea why.
Why?
Try and get to bottom of this issue.
How did you test it?
Unit test pass
Potential risks
nothing