Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and use a limiter struct instead of just passing a function #5454

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

jakobht
Copy link
Contributor

@jakobht jakobht commented Nov 20, 2023

Creates a limiter struct and interface instead of just passing a function - will create dedicated factories later

What changed?
We now parse a LimiterFactory to the quotas.Collection instead of just a function, this gives the code more structure

Why?
The code is very hard to read when all state are kept in closures

How did you test it?
Unit tests still pass

Potential risks

Release notes

Documentation Changes

@jakobht jakobht marked this pull request as ready for review November 20, 2023 10:03
@jakobht jakobht merged commit cf07398 into uber:master Nov 22, 2023
16 checks passed
@jakobht jakobht deleted the rateLimitCleanup branch November 22, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants