Wrap isSecure config in config map for kafka topic #5474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neil-xie
requested review from
Shaddoll,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
taylanisikdemir
approved these changes
Dec 11, 2023
davidporter-id-au
approved these changes
Dec 11, 2023
Groxx
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
yea, probably worth the get(topic, prop) API for unpacking that structure, which seems reasonable.
maybe one day we'll have a more standardized "externally-extendable config" thing. but this seems fine for now, and it's constrained enough that changing it later should be fairly safe / straight-forward for anyone using it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Unexpose isSecure config, replace with config map
Why?
IsSecure is internal config for kafka topic, we don't want it to be exposed for public users
How did you test it?
Potential risks
Release notes
Documentation Changes