Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Debugf and some minor updates to timer queue processor base #5475

Merged

Conversation

taylanisikdemir
Copy link
Contributor

@taylanisikdemir taylanisikdemir commented Dec 12, 2023

What changed?

  • Some non-behavioral changes in timer queue processor:
    • add debug logs
    • reduce unnecessary multiline formatting
    • wrap too many return parameters in a struct
    • move handling logic to helper functions to make processing loop more lean/readable
  • Introduce Debugf as a shortcut to logger.Debug(fmt.Sprintf(..)).
  • Use zaplogger's Check() to avoid processing log tags for Debug logs. Since we plan to add more verbose logs this can help reduce GC overhead in prod.

Misc. change:

  • Added 30s sleep before running unit test CI job as workaround to failing make install-schema due to Cassandra not ready.

Why?
Improve debugging

How did you test it?
make test

@taylanisikdemir taylanisikdemir merged commit d4f0fd7 into uber:master Dec 13, 2023
16 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/timer_q_proc_base_logging branch December 13, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants