Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for AwaitWaitGroup #5512

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Add unit tests for AwaitWaitGroup #5512

merged 2 commits into from
Dec 20, 2023

Conversation

arzonus
Copy link
Contributor

@arzonus arzonus commented Dec 20, 2023 •
edited

What changed?
Addition of unit tests

Why?
AwaitWaitGroup didn't have test

How did you test it?
unit tests passed

Potential risks

Release notes

Documentation Changes

@arzonus arzonus enabled auto-merge (squash) December 20, 2023 14:12
3vilhamster
3vilhamster approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@3vilhamster 3vilhamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though having a common function with time.After is a sad thing.

@arzonus arzonus merged commit 636b5d0 into uber:master Dec 20, 2023
16 checks passed
@arzonus arzonus deleted the CDNC-6460-add-tests-for-await-wait-group branch December 20, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3vilhamster 3vilhamster 3vilhamster approved these changes

@Shaddoll Shaddoll Awaiting requested review from Shaddoll Shaddoll is a code owner

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie is a code owner

@davidporter-id-au davidporter-id-au Awaiting requested review from davidporter-id-au davidporter-id-au is a code owner

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@agautam478 agautam478 Awaiting requested review from agautam478 agautam478 is a code owner

@jakobht jakobht Awaiting requested review from jakobht jakobht is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@taylanisikdemir taylanisikdemir Awaiting requested review from taylanisikdemir taylanisikdemir is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arzonus @3vilhamster