Test for error injection clients #5515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3vilhamster
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
3vilhamster
force-pushed
the
injection_error_tests
branch
3 times, most recently
from
d0a0f81
to
9dc4a56
Compare
taylanisikdemir
approved these changes
Dec 21, 2023
3vilhamster
force-pushed
the
injection_error_tests
branch
from
c2d66c0
to
c521af7
Compare
3vilhamster
force-pushed
the
injection_error_tests
branch
from
0b6bda2
to
cf36bbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Improving test coverage for error injection wrappers.
Persistence layer exposes error injection wrappers around all of the provided interfaces.
All wrappers follows the same logic and returns error on a provided rate, with extra logic for Timeout and Unhandled errors that are bypassing the wrapper.
I've added generation logic so these wrappers now autogenerated and moved all the wrapper into a separate package, separated them by type and provided a common tests form 0 rate, 100 rate and underlying errors.
Test coverage now is on 98%.
Why?
Improving test coverage and code readability.
How did you test it?
Unit tests.
Potential risks
Release notes
Documentation Changes