Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit tests for ValidIDLength #5520

Merged
merged 5 commits into from
Dec 21, 2023

Conversation

arzonus
Copy link
Contributor

@arzonus arzonus commented Dec 21, 2023

What changed?
unit tests have been added

Why?
ValidIDLength is not covered

How did you test it?
Unit tests are passed

Potential risks

Release notes

Documentation Changes

common/util.go Show resolved Hide resolved
common/util_test.go Show resolved Hide resolved
common/util.go Show resolved Hide resolved
@arzonus arzonus enabled auto-merge (squash) December 21, 2023 13:59
@arzonus arzonus merged commit 2913db2 into uber:master Dec 21, 2023
16 checks passed
@arzonus arzonus mentioned this pull request Dec 22, 2023
@arzonus arzonus deleted the CDNC-6460-add-tests-for-valid-if-length branch December 22, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants