Make sure task processing rate limiter is only done in the active side #5654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sankari165
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
jakobht
approved these changes
Feb 12, 2024
| @@ -195,6 +196,10 @@ func (t *transferActiveTaskExecutor) processActivityTask( | |||
| // release the context lock since we no longer need mutable state builder and | |||
| // the rest of logic is making RPC call, which takes time. | |||
| release(nil) | |||
|
|
|||
| // Ratelimiting is not done. This is only to count the number of requests via metrics | |||
| t.wfIDCache.AllowInternal(task.DomainID, task.WorkflowID) | |||
There was a problem hiding this comment.
we need this in timer active task executor as well
There was a problem hiding this comment.
It is not needed for timer tasks because we dont plan to rate limit timer tasks
Pull Request Test Coverage Report for Build 018da1c3-f0a6-4872-a788-97cbe2bbb7adDetails
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Task processing rate limiting metrics is collected only in the active side.
Why?
We do not want to ratelimit task processing in passive side
How did you test it?
local and unit tests
Potential risks
Release notes
Documentation Changes