Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async workflow integration test step to CI #5681

Merged

Conversation

taylanisikdemir
Copy link
Contributor

@taylanisikdemir taylanisikdemir commented Feb 22, 2024

What changed?
Async workflow integration test is introduced in #5678. This PR is adding it to CI pipelines for both pull request and master.

This new integration test only runs async workflow specific test cases and doesn't run the whole suit. Should finish within a few minutes. It also doesn't generate coverage because we don't need that for integration tests.

How did you test it?
Checked the new CI step running as part of this PR.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018dce49-4aac-4c06-8363-21070aa8006c

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 76 unchanged lines in 16 files lost coverage.
  • Overall coverage increased (+0.01%) to 62.787%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 88.06%
common/persistence/historyManager.go 2 66.67%
common/persistence/sql/common.go 2 72.73%
common/persistence/sql/sqlplugin/postgres/db.go 2 85.0%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
service/matching/db.go 2 73.23%
common/log/tag/tags.go 3 50.18%
common/persistence/nosql/nosqlplugin/cassandra/tasks.go 4 76.09%
service/history/task/transfer_standby_task_executor.go 4 87.01%
common/persistence/nosql/nosql_task_store.go 5 61.95%
Totals Coverage Status
Change from base Build 018dce2d-61e6-4ca6-bd29-a148af6ec27c: 0.01%
Covered Lines: 92799
Relevant Lines: 147800

💛 - Coveralls

@taylanisikdemir taylanisikdemir merged commit e88d718 into uber:master Feb 22, 2024
17 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/async_wf_int_test_buildkite branch February 22, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants