Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for cdb.SelectCurrentWorkflow #5693

Merged

Conversation

taylanisikdemir
Copy link
Contributor

What changed?
This PR covers SelectCurrentWorkflow without going too deep into parseWorkflowExecutionInfo helper function. It will be covered separately with a dedicated test function.

Why?
Increase coverage.

@coveralls
Copy link

coveralls commented Feb 28, 2024

Pull Request Test Coverage Report for Build 018df712-b5da-43f8-ab44-aafa2edda07c

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 83 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.02%) to 62.918%

Files with Coverage Reduction New Missed Lines %
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/task/fifo_task_scheduler.go 3 84.54%
service/history/task/fetcher.go 3 85.57%
common/persistence/nosql/nosqlplugin/cassandra/tasks.go 4 76.09%
common/persistence/nosql/nosql_task_store.go 5 61.95%
common/persistence/nosql/nosqlplugin/cassandra/gocql/public/client.go 12 20.93%
common/persistence/sql/workflowStateMaps.go 23 81.25%
service/history/execution/mutable_state_task_refresher.go 29 59.81%
Totals Coverage Status
Change from base Build 018df70f-6bb5-4870-8891-064f2c2770ac: 0.02%
Covered Lines: 92996
Relevant Lines: 147806

💛 - Coveralls

@taylanisikdemir taylanisikdemir enabled auto-merge (squash) February 29, 2024 22:53
@taylanisikdemir taylanisikdemir merged commit 48e9c04 into uber:master Feb 29, 2024
16 of 17 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/select_current_wf_test branch March 1, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants