Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check time type in custom search attribute #5822

Conversation

bowenxia
Copy link
Contributor

What changed?
Add a logic to check time type in custom search attribute.

Why?
Previously, if there's a time.Time() type passed in, like CustomDateTimeField = '2024-02-07T15:32:30Z', there'll be an error.
In order to handle this, I converted it before forming the pinot query.

How did you test it?
unit test

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Merging #5822 (06ec8ef) into master (08e8553) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
Files Coverage Δ
common/pinot/pinotQueryValidator.go 84.52% <100.00%> (+0.31%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08e8553...06ec8ef. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 27, 2024

Pull Request Test Coverage Report for Build 018e8110-fc74-4bc4-902d-3ffb52429a5b

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • 34 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.02%) to 65.272%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
common/task/parallel_task_processor.go 2 93.06%
service/history/task/transfer_active_task_executor.go 2 72.7%
service/matching/taskListManager.go 2 80.46%
service/history/task/transfer_standby_task_executor.go 4 87.42%
common/task/fifo_task_scheduler.go 5 80.41%
common/persistence/nosql/nosqlplugin/cassandra/workflow_parsing_utils.go 17 85.54%
Totals Coverage Status
Change from base Build 018e80b1-cd50-4480-a951-e84d29ca03ec: 0.02%
Covered Lines: 95409
Relevant Lines: 146172

💛 - Coveralls

…ttribute' of github.com:uber/cadence into xbowen_pinotQueryValidator_checkTimeTypeInCustomSearchAttribute
@bowenxia bowenxia enabled auto-merge (squash) March 27, 2024 18:46
Copy link
Contributor

@neil-xie neil-xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bowenxia bowenxia merged commit 3a2a4d9 into master Mar 27, 2024
21 checks passed
@bowenxia bowenxia deleted the xbowen_pinotQueryValidator_checkTimeTypeInCustomSearchAttribute branch March 27, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants