Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for triple manager and renaming a variable in pinot dual manager test #5869

Merged
merged 5 commits into from Apr 4, 2024

Conversation

bowenxia
Copy link
Contributor

@bowenxia bowenxia commented Apr 4, 2024

What changed?
Add unit test for setup functionss (only newFunc, Close, GetName) for triple manager
and renaming a variable in pinot dual manager test

Why?
code coverage week

How did you test it?

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Merging #5869 (e1da072) into master (1f120fd) will increase coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head e1da072 differs from pull request most recent head 4dc1edd. Consider uploading reports for the commit 4dc1edd to get more accurate results

Additional details and impacted files
Files Coverage Δ
...mon/persistence/pinot_visibility_triple_manager.go 8.50% <ø> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64cc6d8...4dc1edd. Read the comment docs.

@bowenxia bowenxia enabled auto-merge (squash) April 4, 2024 21:36
@bowenxia bowenxia merged commit 8f3248c into master Apr 4, 2024
19 checks passed
@bowenxia bowenxia deleted the xbowen_pinot_triple_manager_test00 branch April 4, 2024 22:29
@coveralls
Copy link

coveralls commented Apr 5, 2024

Pull Request Test Coverage Report for Build 018eab06-6e71-4870-ae9a-a8527ce908f5

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.05%) to 66.302%

Files with Coverage Reduction New Missed Lines %
service/history/task/transfer_standby_task_executor.go 2 88.25%
common/task/fifo_task_scheduler.go 2 85.57%
service/history/queue/transfer_queue_processor.go 2 56.75%
service/matching/taskListManager.go 2 80.2%
common/membership/hashring.go 2 82.23%
common/persistence/statsComputer.go 3 96.07%
Totals Coverage Status
Change from base Build 018eaac3-4342-4613-8e92-81e25686f073: 0.05%
Covered Lines: 97010
Relevant Lines: 146315

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants