Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for AppendHistoryNodes #5896

Merged

Conversation

jakobht
Copy link
Contributor

@jakobht jakobht commented Apr 9, 2024

What changed?
Added unit tests for AppendHistoryNodes

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Apr 9, 2024

Pull Request Test Coverage Report for Build 018ec6fc-f796-4505-b8d5-6445fa54b23e

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 72 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-0.04%) to 67.342%

Files with Coverage Reduction New Missed Lines %
service/history/task/transfer_standby_task_executor.go 2 86.19%
service/history/shard/context.go 2 66.7%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/matching/db.go 2 73.23%
common/util.go 2 91.78%
service/history/execution/mutable_state_util.go 2 78.13%
common/membership/hashring.go 2 84.69%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/log/tag/tags.go 3 50.74%
service/history/queue/timer_queue_processor_base.go 3 77.82%
Totals Coverage Status
Change from base Build 018ec3ed-d5a3-4d3b-bd9e-78015bea868b: -0.04%
Covered Lines: 98168
Relevant Lines: 145776

💛 - Coveralls

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Merging #5896 (e9892f4) into master (cd14f34) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head e9892f4 differs from pull request most recent head 27cd2d8. Consider uploading reports for the commit 27cd2d8 to get more accurate results

Additional details and impacted files

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd14f34...27cd2d8. Read the comment docs.

@jakobht jakobht force-pushed the test_nosql_history_storage_AppendHistoryNodes branch from 60c7e04 to e9892f4 Compare April 10, 2024 06:53
@jakobht jakobht force-pushed the test_nosql_history_storage_AppendHistoryNodes branch from e9892f4 to 27cd2d8 Compare April 10, 2024 07:50
@jakobht jakobht enabled auto-merge (squash) April 10, 2024 07:57
@jakobht jakobht merged commit e833741 into uber:master Apr 10, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants