Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-coverage] Add tests for HandleDecisionTaskFailed in service/history/decision #5903

Merged

Conversation

ketsiambaku
Copy link
Contributor

@ketsiambaku ketsiambaku commented Apr 11, 2024

What changed?

Why?
improve code coverage

How did you test it?
Unit tests

Potential risks
N/A

Release notes

Documentation Changes

@ketsiambaku ketsiambaku force-pushed the history-decision-handler-handletaskfailed branch from 1b4ca2f to 2262a20 Compare April 11, 2024 19:52
@ketsiambaku ketsiambaku changed the title [code-coverage] History decision handler handletaskfailed [code-coverage] Add tests for HandleDecisionTaskFailed in service/history/decision Apr 11, 2024
@ketsiambaku ketsiambaku marked this pull request as ready for review April 11, 2024 19:56
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018eceb7-c380-4431-9dc8-04ab8226b030

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 15 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.02%) to 67.375%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
service/history/queue/timer_queue_processor_base.go 1 78.23%
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/task/fifo_task_scheduler.go 2 87.63%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
tools/cli/admin_db_decode_thrift.go 5 66.67%
Totals Coverage Status
Change from base Build 018eca11-8174-48a3-9058-79ba823db2e5: 0.02%
Covered Lines: 98217
Relevant Lines: 145776

💛 - Coveralls

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Merging #5903 (2262a20) into master (7b4b90e) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

see 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b4b90e...2262a20. Read the comment docs.

@ketsiambaku ketsiambaku merged commit 5e98036 into uber:master Apr 11, 2024
20 checks passed
@ketsiambaku ketsiambaku deleted the history-decision-handler-handletaskfailed branch April 14, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants