Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update internal types to adopt new IDL changes #5946

Merged
merged 1 commit into from Apr 26, 2024
Merged

Conversation

Shaddoll
Copy link
Contributor

What changed?
Update internal types to adopt new IDL changes

Why?

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.68%. Comparing base (8868545) to head (ddd4719).

Additional details and impacted files
Files Coverage Δ
common/types/history.go 0.00% <ø> (ø)
common/types/mapper/proto/api.go 98.32% <100.00%> (+<0.01%) ⬆️
common/types/mapper/proto/history.go 99.22% <100.00%> (+<0.01%) ⬆️
common/types/mapper/thrift/history.go 99.49% <100.00%> (+<0.01%) ⬆️
common/types/mapper/thrift/shared.go 97.63% <100.00%> (+<0.01%) ⬆️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8868545...ddd4719. Read the comment docs.

@Shaddoll Shaddoll merged commit 7ea82a5 into uber:master Apr 26, 2024
20 checks passed
@Shaddoll Shaddoll deleted the idls branch April 26, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants