Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write tests for replication task processor main loop #6010

Merged
merged 3 commits into from
May 11, 2024
Merged

Write tests for replication task processor main loop #6010

merged 3 commits into from
May 11, 2024

Conversation

taylanisikdemir
Copy link
Contributor

@taylanisikdemir taylanisikdemir commented May 10, 2024 •
edited
Loading

What changed?
Added more test cases to cover replication/task_processor.go's main processing loop logic.

Why?
Improve coverage

How did you test it?

go test -timeout 60s -run ^TestTaskProcessorSuite$ github.com/uber/cadence/service/history/replication -race -v -count=3

@codecov Codecov
Copy link

codecov bot commented May 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.72%. Comparing base (2fef3c3) to head (72fc20c).
Report is 9 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
service/history/replication/task_executor.go 53.97% <ø> (ø)
service/history/replication/task_processor.go 68.70% <100.00%> (+21.98%) ⬆️

... and 12 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fef3c3...72fc20c. Read the comment docs.

@taylanisikdemir taylanisikdemir enabled auto-merge (squash) May 10, 2024 23:53
@taylanisikdemir taylanisikdemir merged commit 957fd1a into uber:master May 11, 2024
19 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/repl_task_proc_tests branch May 11, 2024 00:04
abhishekj720 pushed a commit to abhishekj720/cadence that referenced this pull request May 13, 2024
@taylanisikdemir @abhishekj720
Write tests for replication task processor main loop (uber#6010)
665e97a
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
@taylanisikdemir @timl3136
Write tests for replication task processor main loop (uber#6010)
1066650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaddoll Shaddoll Shaddoll approved these changes

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie is a code owner

@davidporter-id-au davidporter-id-au Awaiting requested review from davidporter-id-au davidporter-id-au is a code owner

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@agautam478 agautam478 Awaiting requested review from agautam478 agautam478 is a code owner

@jakobht jakobht Awaiting requested review from jakobht jakobht is a code owner

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster 3vilhamster is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@taylanisikdemir @Shaddoll