Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering by CloseStatus in ListAllWorkflowExecutions api #6133

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

sankari165
Copy link
Contributor

@sankari165 sankari165 commented Jun 13, 2024

What changed?
Filtering by a list of closestatus in listallworkflowexecutions api.

Why?
So webv4 can make it possible to filter on workflow status

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.22%. Comparing base (bf8cb36) to head (bfa10b1).

Additional details and impacted files
Files Coverage Δ
...mon/persistence/dataVisibilityManagerInterfaces.go 0.00% <ø> (ø)
common/persistence/data_store_interfaces.go 100.00% <ø> (ø)
common/persistence/pinot/pinot_visibility_store.go 93.15% <100.00%> (+0.09%) ⬆️
common/persistence/visibility_single_manager.go 99.22% <100.00%> (+<0.01%) ⬆️
service/frontend/api/handler.go 65.27% <100.00%> (+0.01%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf8cb36...bfa10b1. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 13, 2024

Pull Request Test Coverage Report for Build 0190129f-33c2-48ec-927f-cb7cb1309a3d

Details

  • 23 of 23 (100.0%) changed or added relevant lines in 3 files are covered.
  • 14 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.02%) to 71.464%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/cache/lru.go 2 93.01%
service/history/queue/transfer_queue_processor.go 2 56.49%
service/matching/tasklist/matcher.go 2 90.91%
common/persistence/nosql/nosql_task_store.go 3 85.52%
common/persistence/statsComputer.go 3 98.21%
Totals Coverage Status
Change from base Build 01901178-520a-4ecd-8c17-3722bda71894: 0.02%
Covered Lines: 106569
Relevant Lines: 149123

💛 - Coveralls

@sankari165 sankari165 merged commit ceff8ca into uber:master Jun 14, 2024
20 checks passed
@sankari165 sankari165 deleted the CDNC-9446 branch June 14, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants