Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing get_cumgain produces errors #717

Closed
ras44 opened this issue Nov 28, 2023 · 1 comment
Closed

Testing get_cumgain produces errors #717

ras44 opened this issue Nov 28, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@ras44
Copy link
Collaborator

ras44 commented Nov 28, 2023

Describe the bug
Not sure if this is just on my fork, but I'm seeing multiple errors when running tests related to 'tau' key not being defined.

image

Currently it looks like "treatment_effect_col" is passed in the dataframe "auuc_metrics", but when calculating get_cumgain it expects the col to be named "tau":

image

To Reproduce
Steps to reproduce the behavior:

see test log

Expected behavior
Success.

Screenshots
See above

Environment (please complete the following information):

  • OS: [Ubuntu]
  • Python Version: [3.6, 3.7, 3.8]

Additional context
N/A
@ras44 ras44 added the bug Something isn't working label Nov 28, 2023
ras44 pushed a commit to ras44/causalml that referenced this issue Nov 28, 2023
@rolandrmgservices
fix uber#717 tests KeyError['tau'] not in index
bc7784b
@ras44 ras44 mentioned this issue Nov 28, 2023
Closed
10 tasks
ras44 pushed a commit to ras44/causalml that referenced this issue Nov 29, 2023
@rolandrmgservices
fix uber#717 tests KeyError['tau'] not in index
614cb2b
@ras44
Copy link
Collaborator Author

ras44 commented Nov 29, 2023

closing for now as I need to debug this further

@ras44 ras44 closed this as completed Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ras44