Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return_ci=True is not properly passed in get_ate_ci of the Sensitivity class in sensitivity.py #757

Closed
lee-junseok opened this issue Apr 12, 2024 · 0 comments · Fixed by #759
Labels
bug Something isn't working

Comments

@lee-junseok
Copy link
Contributor

Describe the bug
Some learner's estimate_ate function requires return_ci = True to return ate_lower, ate_upper together with ate. get_ate_ci of the Sensitivity class does not pass return_ci = True to estimate_ate.

To Reproduce
Steps to reproduce the behavior: Run sensitivity_analysis method with a class object Sensitivity(..., learner = XGBTRegressor(...), ...)

It gives
ValueError: not enough values to unpack (expected 3, got 1)

Expected behavior
Get sensitivity analysis result without a ValueError

Screenshots
image
Learner: XGBTRegressor()

Environment (please complete the following information):

  • OS: [Ubuntu (Jupyter notebook)]
  • Python Version: [3.7]
  • Versions of Major Dependencies (pandas, scikit-learn, cython): [pandas==1.35, scikit-learn==1.0, cython==0.29.34]

Additional context
None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants