Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

757: add return_ci=True in sensitivity #758

Merged

Conversation

lee-junseok
Copy link
Contributor

Proposed changes

Issue 757

return_ci=True argument is not passed in the get_ate_ci method of Sensitivity class object and running sensitivity_analysis gives a ValueError for a Tlearner object. Adding return_ci=True to the get_ate_ci method with another nested try/except layer since not all estimate_ate methods of learners that is to be run in get_ate_ci method of Sensitivity take the return_ci argument.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. This PR template is adopted from appium.

@lee-junseok lee-junseok marked this pull request as ready for review April 12, 2024 17:03
@jeongyoonlee jeongyoonlee added the bug Something isn't working label Apr 12, 2024
@jeongyoonlee jeongyoonlee merged commit 12747ee into uber:master Apr 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants