Allow parallel prediction for UpliftRandomForestClassifier #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeongyoonlee
requested changes
Feb 14, 2022
There was a problem hiding this comment.
Thanks @heiderich! Looks good to me. I left one minor change request.
computation for UpliftRandomForestClassifier
of UpliftRandomForestClassifier
of UpliftRandomForestClassifier. It is passed as `prefer` to joblib.Parallel in the `fit` and `predict` methods.
heiderich
force-pushed
the
parallel_predict_UpliftRandomForestClassifier
branch
from
e1ba553
to
b84f114
Compare
jeongyoonlee
approved these changes
Feb 14, 2022
| @@ -1256,7 +1260,8 @@ class UpliftRandomForestClassifier: | |||
| n_reg=10, | |||
| evaluationFunction='KL', | |||
| normalization=True, | |||
| n_jobs=-1): | |||
| n_jobs=-1, | |||
| joblib_prefer: str = "threads"): | |||
There was a problem hiding this comment.
nit: We're going to use black as a formatter as discussed in #474. You can use it integrated in your IDE or run its command line tool to ensure that the code style follows PEP-8. e.g. no white space around = when used in input arguments.
Since we already have a separate PR, you don't need to update the style here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Previous to this PR
UpliftRandomForestClassifierwas usingjoblibto fit theUpliftTreeClassifiers in parallel ifn_jobswas not equal to 1. With this PR predictions are also computed in parallel (one job per tree).Types of changes
What types of changes does your code introduce to CausalML?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.