Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ate pretrain 0506 #511

Merged
merged 6 commits into from May 20, 2022
Merged

Ate pretrain 0506 #511

merged 6 commits into from May 20, 2022

Conversation

vincewu51
Copy link
Collaborator

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Changes made

Links to related issues/PRs
#395

Tests
test/test_meta_learner.py

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [X ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. This PR template is adopted from appium.

X, treatment, y = convert_pd_to_np(X, treatment, y)
te, yhat_cs, yhat_ts = self.fit_predict(X, treatment, y, return_components=True)
if pretrain:
te, yhat_cs, yhat_ts = self.predict(X, treatment, y, return_components=True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QQ: for S-learner if we already have the model, we could has have y=None here right? As what you did for R-leaner.

Copy link
Collaborator Author

@vincewu51 vincewu51 May 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you are right, but since self.predict here also accepts y, treatment as parameters, I included them here.

@vincewu51
Copy link
Collaborator Author

vincewu51 commented May 13, 2022

The checks are throwing error for file 'causalml/inference/tree/causaltree.pyx', but this diff didn't change anything for this file.

@jeongyoonlee Hi Jeong, do you have any past experience on this. The error is on cython.
causalml/inference/tree/causaltree.pyx:136:37: Cannot assign type 'double[::1]' to 'double *'

@vincewu51
Copy link
Collaborator Author

vincewu51 commented May 13, 2022

The checks are throwing error for file 'causalml/inference/tree/causaltree.pyx', but this diff didn't change anything for this file.

@jeongyoonlee Hi Jeong, do you have any past experience on this. The error is on cython. causalml/inference/tree/causaltree.pyx:136:37: Cannot assign type 'double[::1]' to 'double *'

The problem is solved by adding scikit-learn<=1.0.2 in requirement.txt. scikit learn released a new version 1.1.0 recently, it is causing the issue mentioned above. I'll create a separate issue on this.

Link to issue

Copy link
Collaborator

@paullo0106 paullo0106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants