Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject.toml with basic build dependencies for PEP518 compliance #553

Merged
merged 4 commits into from
Sep 20, 2022

Conversation

darthtrevino
Copy link
Contributor

@darthtrevino darthtrevino commented Sep 18, 2022

Proposed changes

I ran into errors when installing this library using Poetry, but by adding a pyproject.toml file with the dependencies necessary at install/build time I was able to resolve this.

Fixes #551

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (see dowhy PR pointing at my fork)

@darthtrevino
Copy link
Contributor Author

@jeongyoonlee, could you review this one? I'm doing some maintenance updates on dowhy, and this is blocking us from upgrading to Poetry 1.2

Copy link
Collaborator

@jeongyoonlee jeongyoonlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@jeongyoonlee jeongyoonlee merged commit 7097e63 into uber:master Sep 20, 2022
@heiderich
Copy link
Contributor

@jeongyoonlee Do you plan to release a new version of causalml any time soon? With this PR merged, this would hopefully make poetry installations easier.

@jeongyoonlee
Copy link
Collaborator

jeongyoonlee commented Jun 21, 2023

Apologize for the delay. The CausalML team has been busy with the upcoming Causal ML KDD workshop. We plan to release a new version by the end of the month. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not installable via Poetry 1.2.0
3 participants