Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ttest criterion #570

Merged
merged 6 commits into from
Jul 8, 2023
Merged

Conversation

volico
Copy link
Contributor

@volico volico commented Nov 10, 2022

Proposed changes

Hi!

I added T-test splitting criteria from Su, Xiaogang, et al. "Subgroup analysis via recursive partitioning." Journal of Machine Learning Research 10.2 (2009). as discussed in #530

In #562 this criteria is added only for binary trees and two-class problems, my PR contributes same splitting criteria for regression task.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@volico volico marked this pull request as draft November 10, 2022 05:24
@volico volico marked this pull request as ready for review November 10, 2022 05:25
Copy link
Collaborator

@jeongyoonlee jeongyoonlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@jeongyoonlee jeongyoonlee merged commit 5632c53 into uber:master Jul 8, 2023
jeongyoonlee pushed a commit that referenced this pull request Jul 8, 2023
* t test criterion for CausalTreeRegressor
* example for t test criterion
* black formatting fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants