Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update to envs/ conda build for precompiled M1 installs #646

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

bsaunders27
Copy link
Contributor

Proposed changes

Follow up to #641 for some missed packages re: dedicated Mac M1 builds

Also updating install of causalml to reference cloned repository setup.py file in order to distinguish from pip method/include pre-release changes.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Sorry I missed these earlier, but now all set on 3.9 conda virtual env building!

Copy link
Collaborator

@jeongyoonlee jeongyoonlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jeongyoonlee jeongyoonlee added the dependencies Pull requests that update a dependency file label Aug 4, 2023
@jeongyoonlee
Copy link
Collaborator

Hi @bsaunders27. Are you still working on this PR? If not, can you make it "Ready for review"?

@jeongyoonlee jeongyoonlee marked this pull request as ready for review August 18, 2023 17:14
@jeongyoonlee jeongyoonlee merged commit 32538b0 into uber:master Aug 18, 2023
3 of 6 checks passed
ras44 pushed a commit to ras44/causalml that referenced this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants