Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"support valid error early stopping" #648

Merged
merged 17 commits into from
Aug 4, 2023
Merged

Conversation

zpppy
Copy link
Contributor

@zpppy zpppy commented Jul 22, 2023

Proposed changes

#614 error reason:cause early_stopping_eval_diff is too small, tree‘s depth is too small.
optimization:
1)early_stopping_eval_diff_scale instead of early_stopping_eval_diff
2)termination condition:
image

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. This PR template is adopted from appium.

@zpppy zpppy changed the title bug fix-"support valid error early stopping" "support valid error early stopping" Jul 23, 2023
Copy link
Collaborator

@jeongyoonlee jeongyoonlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@jeongyoonlee jeongyoonlee merged commit 3b8f42c into uber:master Aug 4, 2023
10 checks passed
@jeongyoonlee jeongyoonlee added the enhancement New feature or request label Aug 4, 2023
ras44 pushed a commit to ras44/causalml that referenced this pull request Aug 22, 2023
* support valid error early stopping

---------

Co-authored-by: Jeong-Yoon Lee <jeongyoon.lee1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants