Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linted with black #663

Merged
merged 1 commit into from
Aug 24, 2023
Merged

linted with black #663

merged 1 commit into from
Aug 24, 2023

Conversation

ras44
Copy link
Collaborator

@ras44 ras44 commented Aug 23, 2023

Proposed changes

Hi @vincewu51, following-up #661 to reformat code with black linter. All tests should pass now except the py3.9, which I believe is an outstanding issue.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@vincewu51
Copy link
Collaborator

Thx. Should we open an issue specifically for the 3.9 fail?

@ras44
Copy link
Collaborator Author

ras44 commented Aug 24, 2023

I believe one is already open at #638

@vincewu51
Copy link
Collaborator

Thanks

@vincewu51 vincewu51 merged commit b9eb51e into uber:master Aug 24, 2023
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants