Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for #701 #705

Merged
merged 1 commit into from Nov 11, 2023
Merged

Hotfix for #701 #705

merged 1 commit into from Nov 11, 2023

Conversation

jeongyoonlee
Copy link
Collaborator

Proposed changes

This PR is a follow-up on #701. It moves the example notebook in ~/examples to docs/examples/, adds it to docs/examples.rst, and updates the notebook header to be consistent with other notebooks.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@jeongyoonlee jeongyoonlee added the documentation Improvements or additions to documentation label Nov 11, 2023
Copy link
Collaborator

@ras44 ras44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for catching that

@jeongyoonlee jeongyoonlee merged commit c154afe into master Nov 11, 2023
10 checks passed
@jeongyoonlee jeongyoonlee deleted the jeong/hotfix_701 branch November 11, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants