Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20240207 honest leaf size #753

Merged
merged 4 commits into from Apr 12, 2024

Conversation

IanDelbridge
Copy link
Contributor

@IanDelbridge IanDelbridge commented Apr 3, 2024

Relating to uplift trees/forests only:
Issue here. Currently, only results are modified when applying updated estimates via honestMethod. Since results does not include the number of samples, one cannot recover the full summary statistics for leaf nodes when using honestMethod. This information can be useful when investigating model behavior or post-hoc statistical analysis.

This PR would

  1. change use fillTree in honestApproach, since that method already does all of the proper updating.
  2. Since (1) would remove all code usages of modifyEstimation, that method is removed.

technically this is a breaking change since modifyEstimation was a public method.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. This PR template is adopted from appium.

@CLAassistant
Copy link

CLAassistant commented Apr 3, 2024

CLA assistant check
All committers have signed the CLA.

@jeongyoonlee
Copy link
Collaborator

Thanks for your contribution, @IanDelbridge! Please sign the Contributor License Agreement (CLA) when you can.

@IanDelbridge IanDelbridge marked this pull request as ready for review April 5, 2024 13:01
@IanDelbridge
Copy link
Contributor Author

Of course, @jeongyoonlee! I just needed to confirm with my company's legal team before signing. The CLA is signed now.

Copy link
Collaborator

@jeongyoonlee jeongyoonlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jeongyoonlee jeongyoonlee merged commit d4a19a2 into uber:master Apr 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants