fix picking bug

modules/core/src/lib/deck-picker.js

@@ -102,8 +102,7 @@ export default class DeckPicker {
   }
 
   // Returns a new picking info object by assuming the last picked object is still picked
-  getLastPickedObject({x, y, layers, viewports}) {
-    const lastPickedInfo = this.lastPickedInfo.info;
+  getLastPickedObject({x, y, layers, viewports}, lastPickedInfo = this.lastPickedInfo.info) {
     const lastPickedLayerId = lastPickedInfo && lastPickedInfo.layer && lastPickedInfo.layer.id;
     const layer = lastPickedLayerId ? layers.find(l => l.id === lastPickedLayerId) : null;
     const coordinate = viewports[0] && viewports[0].unproject([x, y]);

modules/core/src/lib/deck.js

@@ -128,6 +128,7 @@ export default class Deck {
 
     this._needsRedraw = true;
     this._pickRequest = {};
+    this._pickedInfo = null;
 
     this.viewState = props.initialViewState || null; // Internal view state if no callback is supplied
     this.interactiveState = {
@@ -163,6 +164,7 @@ export default class Deck {
   finalize() {
     this.animationLoop.stop();
     this.animationLoop = null;
+    this._pickedInfo = null;
 
     if (this.layerManager) {
       this.layerManager.finalize();
@@ -465,7 +467,7 @@ export default class Deck {
   // The `pointermove` event may fire multiple times in between two animation frames,
   // it's a waste of time to run picking without rerender. Instead we save the last pick
   // request and only do it once on the next animation frame.
-  _requestPick({event, callback, mode, immediate}) {
+  _requestPick({event, callback, mode}) {
     const {_pickRequest} = this;
     if (event.type === 'pointerleave') {
       _pickRequest.x = -1;
@@ -486,10 +488,6 @@ export default class Deck {
     _pickRequest.callback = callback;
     _pickRequest.event = event;
     _pickRequest.mode = mode;
-
-    if (immediate) {
-      this._pickAndCallback();
-    }
   }
 
   // Actually run picking
@@ -705,12 +703,15 @@ export default class Deck {
 
     // Reuse last picked object
     const layers = this.layerManager.getLayers();
-    const info = this.deckPicker.getLastPickedObject({
-      x: pos.x,
-      y: pos.y,
-      layers,
-      viewports: this.getViewports(pos)
-    });
+    const info = this.deckPicker.getLastPickedObject(
+      {
+        x: pos.x,
+        y: pos.y,
+        layers,
+        viewports: this.getViewports(pos)
+      },
+      this._pickedInfo
+    );
 
     const {layer} = info;
     const layerHandler =
@@ -727,11 +728,10 @@ export default class Deck {
   }
 
   _onPointerDown(event) {
-    this._requestPick({
-      callback: null,
-      event,
-      mode: 'hover',
-      immediate: true
+    const pos = event.offsetCenter;
+    this._pickedInfo = this.pickObject({
+      x: pos.x,
+      y: pos.y
     });
   }