Skip to content

Commit

Permalink
tweaks
Browse files Browse the repository at this point in the history
  • Loading branch information
Xiaoji Chen committed Jun 7, 2019
1 parent 6cdfc7c commit 6a61ee0
Showing 1 changed file with 2 additions and 13 deletions.
15 changes: 2 additions & 13 deletions dev-docs/RFCs/vNext/layer-extension-rfc.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,17 +27,6 @@ To mitigate this, we can of course add as many customizable functionalities to t

* Shader module: `project64` (replaces `project32`)

### Picking

Components:

* Props: `pickable`, `autoHighlight`, `highlightedObjectIndex`, `highlightColor`
* Shader module: `picking`
* Attribute: `instancePickingColors` (generated regardless of the `pickable` setting)
* Shader injection:
- Vertex shader: `picking_setPickingColor(instancePickingColors);`
- Fragment shader: `gl_FragColor = picking_filterHighlightColor(gl_FragColor); gl_FragColor = picking_filterPickingColor(gl_FragColor);`

### Data Filter

See [Data Filter RFC](/dev-docs/RFCs/v6.0/data-filter-rfc.md)
Expand All @@ -62,7 +51,7 @@ A generic version of this functionality would need the following components:
* Shader injection:
- Vertex shader: `brush_setVisibility(instancePositions);`
- Frament shader: `gl_FragColor = brush_filterColor(gl_FragColor);`

* Subscribe to hover events and store the mouse position in layer state

## Proposal

Expand Down Expand Up @@ -111,7 +100,7 @@ new Deck({
})
```

The default value of `extensions` is `[new Picking()]`.
The default value of `extensions` is `[]`.

Pros:

Expand Down

0 comments on commit 6a61ee0

Please sign in to comment.