update docs

visgl · Oct 3, 2019 · 999e169 · 999e169
1 parent 791b888
commit 999e169
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/docs/api-reference/deck.md b/docs/api-reference/deck.md
@@ -203,6 +203,10 @@ gl context, will be autocreated if not supplied.
 
 Additional options used when creating the WebGLContext. See [WebGL context attributes](https://developer.mozilla.org/en-US/docs/Web/API/HTMLCanvasElement/getContext).
 
+##### `_framebuffer` (Object, optional)
+
+(Experimental) Render to a custom frame buffer other than to screen.
+
 ##### `parameters` (Object, optional)
 
 Expects an object with WebGL settings. This object will be passed to luma.gl's `setParameters` function to configure the WebGL context, e.g. to disable depth testing, change blending modes etc.

diff --git a/modules/core/src/lib/deck-renderer.js b/modules/core/src/lib/deck-renderer.js
@@ -53,9 +53,9 @@ export default class DeckRenderer {
       effects
     });
 
-    const target = framebuffer || (this.lastPostProcessEffect
-      ? this.screenBuffer
-      : Framebuffer.getDefaultFramebuffer(this.gl));
+    const target =
+      framebuffer ||
+      (this.lastPostProcessEffect ? this.screenBuffer : Framebuffer.getDefaultFramebuffer(this.gl));
 
     const renderStats = layerPass.render({
       layers,

diff --git a/modules/core/src/passes/pick-layers-pass.js b/modules/core/src/passes/pick-layers-pass.js
@@ -35,7 +35,6 @@ export default class PickLayersPass extends LayersPass {
     return withParameters(
       gl,
       {
-        framebuffer: pickingFBO,
         scissorTest: true,
         scissor: [x, y, width, height],
         clearColor: [0, 0, 0, 0],

diff --git a/test/apps/framebuffer/app.js b/test/apps/framebuffer/app.js
@@ -74,4 +74,4 @@ function onAfterRender() {
 }
 
 /* global document */
-document.body.style.margin = '0px';
+document.body.style.margin = '0px';