Skip to content

Commit

Permalink
Address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
1chandu committed Dec 18, 2019
1 parent 1f7ed98 commit e6880f6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
2 changes: 1 addition & 1 deletion modules/aggregation-layers/src/aggregation-layer.js
Expand Up @@ -80,7 +80,7 @@ export default class AggregationLayer extends CompositeLayer {
* Checks if aggregation is dirty
* @param {Object} updateOpts - object {props, oldProps, changeFlags}
* @param {Object} params - object {dimension, compareAll}
* @param {Object} params.dimension - {props, accessors} array of props and/pr accessors
* @param {Object} params.dimension - {props, accessors} array of props and/or accessors
* @param {Boolean} params.compareAll - when `true` it will include non layer props for comparision
* @returns {Boolean} - returns true if dimensions' prop or accessor is changed
**/
Expand Down
10 changes: 0 additions & 10 deletions modules/aggregation-layers/src/aggregation-layer.md
Expand Up @@ -52,13 +52,3 @@ This helper can be used if a dimension is changed. Sublayers can defined custom
### isAttributeChanged()

`AggregationLayer` tracks what attributes are changed in each update cycle. Super classes can use `isAttributeChanged()` method to check if a specific attribute is changed or any attribute is changed.

#### Aggregation State

`AggregationLayer` is responsible for setting following values in `sate` object:

* `positionsChanged` : Set to `true` when the position attribute is changed. Super layers must set `state.positionAttributeName`, to define the name of position attribute, by default `positions` is used as name of position attribute. This flag, can be used to re compute aggregation parameters that depend on position data, such as bounding-box etc.

* `attributesChanged` : Set to `true`, when any of the attributes are changed. This flag can be used to re-trigger aggregation.

It is up to the subclasses how to use these flags, based on aggregation needs. For example, GPU aggregation layer can trigger re aggregation when `attributesChanged`.

0 comments on commit e6880f6

Please sign in to comment.